[Skiboot] [PATCH] make check: Use mktemp instead of tempfile

Stewart Smith stewart at linux.vnet.ibm.com
Mon Jul 18 13:36:56 AEST 2016


Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:

> Commit 2ceb8b8c (make check: make test runs less noisy) used tempfile
> command to create temporary files. Looks like distros like Fedora
> doesn't have tempfile command.
>
> Looks like mktemp is supported on all distros (at least Fedora and
> Ubuntu supports this command). Hence replace tempfile with mktemp.
>
> Output without patch:
>   [ CLEANUP ]   gard-test-clean
>   ./test/run.sh: line 3: tempfile: command not found
>   skiboot/external/gard/test/Makefile.check:18: recipe for target 'gard-test-clean' failed
> 	make: *** [gard-test-clean] Error 1
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> CC: Stewart Smith <stewart at linux.vnet.ibm.com>
> ---
>  test/run.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks (and sorry) - merged to master as of 8f54232

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list