[Skiboot] [PATCH 2/2] platforms/ibm-fsp: Use power_ctl bit when determining slot reset method

Suraj Jitindar Singh sjitindarsingh at gmail.com
Mon Jul 18 16:25:33 AEST 2016

On 18/07/16 15:49, Russell Currey wrote:
> On Mon, 2016-07-18 at 15:26 +1000, Suraj Jitindar Singh wrote:
>> The power_ctl bit is used to represent if power management is available.
>> Use this bit when determining the slot reset method. If it is set then
>> we see if we can use fundamental reset, otherwise we try to use hot
>> reset.
>> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>
>> Acked-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>> ---
> Pulling out the existing power management code into its own function makes it
> hard to determine what's changed.  It looks like nothing's changed except this
> setup is only performed if power management is available, right?  What was the
> existing behaviour is power_ctl isn't set?

Correct, this setup is only performed if external power management is available,
as indicated by the power_ctl bit being set. I figured since git blame was going
to be clobbered anyway I might as well move this to a new function to improve

Previously power_ctl was never used, but since we now set it correctly it is worth
using it to gate the setup code since this is only going to be useful when external
power management is available.

> It's also not clear from the commit message how the reset method is affected,
> given no reset-related code is touched in this patch.  The commit message and
> patch seem pretty unrelated.

Alright, I'll re-write the commit message to better reflect what the patch does.

More information about the Skiboot mailing list