[Skiboot] [PATCH 2/2] platforms/ibm-fsp: Use power_ctl bit when determining slot reset method

Russell Currey ruscur at russell.cc
Mon Jul 18 15:49:07 AEST 2016

On Mon, 2016-07-18 at 15:26 +1000, Suraj Jitindar Singh wrote:
> The power_ctl bit is used to represent if power management is available.
> Use this bit when determining the slot reset method. If it is set then
> we see if we can use fundamental reset, otherwise we try to use hot
> reset.
> Signed-off-by: Suraj Jitindar Singh <sjitindarsingh at gmail.com>
> Acked-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> ---

Pulling out the existing power management code into its own function makes it
hard to determine what's changed.  It looks like nothing's changed except this
setup is only performed if power management is available, right?  What was the
existing behaviour is power_ctl isn't set?

It's also not clear from the commit message how the reset method is affected,
given no reset-related code is touched in this patch.  The commit message and
patch seem pretty unrelated.

More information about the Skiboot mailing list