[Skiboot] [PATCH 02/28] XIVE: Base XIVE support for OPAL XICS emulation calls

[Stewart Smith]

Stewart Smith <stewart at linux.vnet.ibm.com> writes:
> Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
>> --- /dev/null
>> +++ b/hw/xive.c
>> @@ -0,0 +1,1985 @@
>
> I'm good to take this as is, couple of little things:
>
> I added in a (C) header here.
>
> <snip>
>
>> +static int64_t __xive_cache_scrub(struct xive *x, enum xive_cache_type ctype,
>> +				  uint64_t block, uint64_t idx,
>> +				  bool want_inval, bool want_disable)
>> +{
>> +	uint64_t sreg, sregx, mreg, mregx;
>> +	uint64_t mval, sval;
>> +
>> +	switch (ctype) {
>> +	case xive_cache_ivc:
>> +		sreg = VC_IVC_SCRUB_TRIG;
>> +		sregx = X_VC_IVC_SCRUB_TRIG;
>> +		mreg = VC_IVC_SCRUB_MASK;
>> +		mregx = X_VC_IVC_SCRUB_MASK;
>> +		break;
>> +	case xive_cache_sbc:
>> +		sreg = VC_SBC_SCRUB_TRIG;
>> +		sregx = X_VC_SBC_SCRUB_TRIG;
>> +		mreg = VC_SBC_SCRUB_MASK;
>> +		mregx = X_VC_SBC_SCRUB_MASK;
>> +	case xive_cache_eqc:
>> +		sreg = VC_EQC_SCRUB_TRIG;
>> +		sregx = X_VC_EQC_SCRUB_TRIG;
>> +		mreg = VC_EQC_SCRUB_MASK;
>> +		mregx = X_VC_EQC_SCRUB_MASK;
>> +	case xive_cache_vpc:
>> +		sreg = PC_VPC_SCRUB_TRIG;
>> +		sregx = X_PC_VPC_SCRUB_TRIG;
>> +		mreg = PC_VPC_SCRUB_MASK;
>> +		mregx = X_PC_VPC_SCRUB_MASK;
>> +	}
>
> hw/xive.c:634 __xive_cache_scrub() warn: missing break? reassigning
> 'sreg'


As mentioned on IRC, i'll add in the breaks.

-- 
Stewart Smith
OPAL Architect, IBM.