[Skiboot] [PATCH 02/28] XIVE: Base XIVE support for OPAL XICS emulation calls

[Stewart Smith]

Benjamin Herrenschmidt <benh at kernel.crashing.org> writes:
> --- /dev/null
> +++ b/hw/xive.c
> @@ -0,0 +1,1985 @@

I'm good to take this as is, couple of little things:

I added in a (C) header here.

<snip>

> +static int64_t __xive_cache_scrub(struct xive *x, enum xive_cache_type ctype,
> +				  uint64_t block, uint64_t idx,
> +				  bool want_inval, bool want_disable)
> +{
> +	uint64_t sreg, sregx, mreg, mregx;
> +	uint64_t mval, sval;
> +
> +	switch (ctype) {
> +	case xive_cache_ivc:
> +		sreg = VC_IVC_SCRUB_TRIG;
> +		sregx = X_VC_IVC_SCRUB_TRIG;
> +		mreg = VC_IVC_SCRUB_MASK;
> +		mregx = X_VC_IVC_SCRUB_MASK;
> +		break;
> +	case xive_cache_sbc:
> +		sreg = VC_SBC_SCRUB_TRIG;
> +		sregx = X_VC_SBC_SCRUB_TRIG;
> +		mreg = VC_SBC_SCRUB_MASK;
> +		mregx = X_VC_SBC_SCRUB_MASK;
> +	case xive_cache_eqc:
> +		sreg = VC_EQC_SCRUB_TRIG;
> +		sregx = X_VC_EQC_SCRUB_TRIG;
> +		mreg = VC_EQC_SCRUB_MASK;
> +		mregx = X_VC_EQC_SCRUB_MASK;
> +	case xive_cache_vpc:
> +		sreg = PC_VPC_SCRUB_TRIG;
> +		sregx = X_PC_VPC_SCRUB_TRIG;
> +		mreg = PC_VPC_SCRUB_MASK;
> +		mregx = X_PC_VPC_SCRUB_MASK;
> +	}

hw/xive.c:634 __xive_cache_scrub() warn: missing break? reassigning
'sreg'

Are there meant to be breaks in here? Can come as additional patch, as
obviously things work well enough in sim :)

> --- /dev/null
> +++ b/include/xive.h
> @@ -0,0 +1,363 @@
> +#ifndef __XIVE_H__
> +#define __XIVE_H__

I also added in a (C) header.

-- 
Stewart Smith
OPAL Architect, IBM.