[Skiboot] [PATCH] FSP/ELOG: Remove redundant validation

[Mukesh Ojha]

Hi Vasant,

On Saturday 02 July 2016 08:17 PM, Vasant Hegde wrote:
> We don't need to validate msg->resp message as its always
> allocated.
>
> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
> ---
>   hw/fsp/fsp-elog-read.c |    2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/hw/fsp/fsp-elog-read.c b/hw/fsp/fsp-elog-read.c
> index a8e5c12..e9332af 100644
> --- a/hw/fsp/fsp-elog-read.c
> +++ b/hw/fsp/fsp-elog-read.c
> @@ -99,8 +99,6 @@ static void fsp_elog_ack_complete(struct fsp_msg *msg)
>   {
>   	uint8_t val;
>   
> -	if (!msg->resp)
> -		return;

Yeah, This became redundant after your patch on message response memory 
allocation check.
("[PATCH] FSP: Validate fsp_msg response memory allocation:")

Reviewed-by: Mukesh Ojha <mukesh02 at linux.vnet.ibm.com>

-Mukesh

>   	val = (msg->resp->word1 >> 8) & 0xff;
>   	if (val != 0)
>   		prerror("ELOG: Acknowledgment error\n");
>
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot