[Skiboot] [PATCH] FSP/ELOG: Remove redundant validation

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Sun Jul 3 00:47:46 AEST 2016


We don't need to validate msg->resp message as its always
allocated.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/fsp/fsp-elog-read.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/fsp/fsp-elog-read.c b/hw/fsp/fsp-elog-read.c
index a8e5c12..e9332af 100644
--- a/hw/fsp/fsp-elog-read.c
+++ b/hw/fsp/fsp-elog-read.c
@@ -99,8 +99,6 @@ static void fsp_elog_ack_complete(struct fsp_msg *msg)
 {
 	uint8_t val;
 
-	if (!msg->resp)
-		return;
 	val = (msg->resp->word1 >> 8) & 0xff;
 	if (val != 0)
 		prerror("ELOG: Acknowledgment error\n");



More information about the Skiboot mailing list