[Skiboot] [PATCH] Subject: libflash: Support for Micron N25Q256Ax and Winbond W25Q256BV NOR flash

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Fri Jan 22 21:08:23 AEDT 2016


On 01/22/2016 08:15 AM, Andrew Donnellan wrote:
> On 21/01/16 06:31, Adriana Kobylak wrote:
>> These 32MB chips are used in the Barreleye OpenBMC BMC.
>>
>> From: Adriana Kobylak <anoo at us.ibm.com>
> 
> The From: line needs to go at the top of the patch for git to see it. If you use
> "git config" to set "user.name" and "user.email" to your IBM address so your
> commit is recorded accordingly, then I *think* git send-email should notice that
> and put in the From header for you (I might be wrong, I use the same account for
> my committer ID and my email, so I've never needed to do this).

Adriana,


Also Signed-off-by is missing. I think once you make above changes then it will
add automatically.
Otherwise use  commands like git commit -s .. it will add your s-o-b automatically.

Go through submitting patch [1] documentation in kernel. It will help.

[1]https://www.kernel.org/doc/Documentation/SubmittingPatches

-Vasant



More information about the Skiboot mailing list