[Skiboot] [PATCH] hw/phb3: fix error handling in complete reset
stewart at linux.vnet.ibm.com
Wed Dec 14 16:09:58 AEDT 2016
Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> On 13/12/16 16:25, Stewart Smith wrote:
>> Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
>>> During a complete reset, when we get a timeout waiting for pending
>>> transaction in state PHB3_STATE_CRESET_WAIT_CQ, we mark the PHB as
> For the record, this should've read "PHB3_SLOT_CRESET_WAIT_CQ" for the
> 5.4+ version of this patch. Apologies.
>>> permanently broken.
>>> Set the state to PHB3_STATE_FENCED so that the kernel can retry the
>>> complete reset.
>>> Reported-by: Pradipta Ghosh <pradghos at in.ibm.com>
>>> Suggested-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
>>> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
>>> This applies on top of mainline.
>>> See also: http://patchwork.ozlabs.org/patch/697595/
>> should this also go to stable? i.e. 5.4.x ?
>> merged to master as of 7fe3de4
> Thanks Stewart!
> Yes, it should go to stable 5.4 as well - I'd forgotten about that. I
> see you've already applied the patch for the 5.1 branch.
Merged at b58048b in skiboot-5.4.x
OPAL Architect, IBM.
More information about the Skiboot