[Skiboot] [PATCH stable 5.1] hw/phb3: fix error handling in complete reset

Stewart Smith stewart at linux.vnet.ibm.com
Tue Dec 13 15:50:14 AEDT 2016

Andrew Donnellan <andrew.donnellan at au1.ibm.com> writes:
> During a complete reset, when we get a timeout waiting for pending
> transaction in state PHB3_STATE_CRESET_WAIT_CQ, we mark the PHB as broken
> and return OPAL_PARAMETER.
> Change the return code to OPAL_HARDWARE which is way more sensible, and set
> the state to PHB3_STATE_FENCED so that the kernel can retry the complete
> reset.
> Reported-by: Pradipta Ghosh <pradghos at in.ibm.com>
> Suggested-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> Acked-by: Gavin Shan <gwshan at linux.vnet.ibm.com>
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>
> ---
> This patch applies on top of skiboot 5.1.18. I'm going to submit a similar 
> fix for mainline.
> This patch goes along with Russell's kernel patch at [0] that fixes the 
> handling of return values from the skiboot reset functions.
> [0] http://patchwork.ozlabs.org/patch/695990/

Thanks, merged to 5.1.x as of 284c465

Stewart Smith
OPAL Architect, IBM.

More information about the Skiboot mailing list