[Skiboot] [PATCH v3 0/6] Enable basic VAS support

Balbir Singh bsingharora at gmail.com
Mon Dec 12 21:44:26 AEDT 2016



On 09/12/16 10:34, Sukadev Bhattiprolu wrote:
>>> 'vas' should show up under each chip of course. I can fold that change
>>> into one of my patches, but do we need to do anything else at this point?
> 
>> I think it would be nice to add uvw/hvwc addresses/mask? number of windows/
> 
> By "mask" do you mean the valid_wcm_mask?
> 
>          *
>          * Use the following bitmask to identify valid offsets in the window
>          * context. Refer to Table 3.2 in the VAS workbook for list of valid
>          * offsets.
>          */
> 
>         uint64_t valid_wcm_mask = 0x00D71FFF13F7D77CULL;
> 
> If so, we might be able to drop the whole init_windows() function from
> skiboot, since kernel will initialize the windows before each use.
> 

The idea is to have the design of DT is to allow the DT to abstract future
hardware changes, such that the kernel will require little or no changes, IMHO.

Balbir


More information about the Skiboot mailing list