[Skiboot] [PATCH v3 0/6] Enable basic VAS support

Sukadev Bhattiprolu sukadev at linux.vnet.ibm.com
Fri Dec 9 10:34:32 AEDT 2016

> > 'vas' should show up under each chip of course. I can fold that change
> > into one of my patches, but do we need to do anything else at this point?

> I think it would be nice to add uvw/hvwc addresses/mask? number of windows/

By "mask" do you mean the valid_wcm_mask?

         * Use the following bitmask to identify valid offsets in the window
         * context. Refer to Table 3.2 in the VAS workbook for list of valid
         * offsets.

        uint64_t valid_wcm_mask = 0x00D71FFF13F7D77CULL;

If so, we might be able to drop the whole init_windows() function from
skiboot, since kernel will initialize the windows before each use.

> size of windows, etc. I am not a DT expert, but it would be good to get broader
> opinion

I am not either and I have a TODO in the kernel patch to visit this later


The rest are all constants for Power9 and was not clear that the they need
to be pushed through the device tree and parsed in the kernel. If any of
them changed for Power10 we would have better understanding of the DT
requirements and could deal with it then? Replacing the macros with code
to get from DT will not affect the kernel or user API.

Stewart, Mikey, please let us know your thoughts on this?


More information about the Skiboot mailing list