[Skiboot] [PATCH] sensor: add a family field in the handler

Stewart Smith stewart at linux.vnet.ibm.com
Thu Dec 8 13:37:10 AEDT 2016


Cédric Le Goater <clg at kaod.org> writes:
> Currently, we are hijacking the last bit of the resource field of the
> sensor handler to differentiate the sensor families and route the
> opal_sensor_read() call to the appropriate component.
>
> Let's reserve the last 3bits and provide an API to set the sensor
> family for current use and future use. This gives us a maximum of 8
> families and 32 resource classes. The FSP uses 15, so we should be
> fine for a while.
>
> Signed-off-by: Cédric Le Goater <clg at kaod.org>
> ---
>  core/sensor.c                        |    4 +++-
>  doc/device-tree/ibm,opal/sensors.rst |    9 ++++++---
>  hw/dts.c                             |    6 +++---
>  hw/fsp/fsp-sensor.c                  |    2 +-
>  include/sensor.h                     |   34 +++++++++++++++++++++-------------
>  5 files changed, 34 insertions(+), 21 deletions(-)

Ahh great, thanks for looking back at this.

I've merged to master as of 33fada1 and also fiddled with the
documentation to say that our encoding scheme is meant to be opaque to
the OS.

-- 
Stewart Smith
OPAL Architect, IBM.



More information about the Skiboot mailing list