[Skiboot] [RFC 0/3] More FFS capabilities

[Cyril Bur]

On Thu, 28 Apr 2016 09:01:22 -0500
Patrick Williams <patrick at stwcx.xyz> wrote:

> In the original ffs tool, the flags were a free form set of user data word. This patch set attempts to enumerate the flags even though many of them are not of concern to skiboot but are used only by hostboot. I suspect some of them are changing for P9. 
> 

This tool isn't really for/about skiboot though, it is about making a PNOR that
can be booted so it needs to be aware of all the flags. I've written it in such
a way that if I get a spec of how the FFS structure is changing in P9 I can
very easily update the code.

There is a discussion to be had about cleaning up the external/ directory
within skiboot. This work is mostly me procrastinating other work but I don't
like autotools enough to use that as a procrastination tool...

> Can we give a mechanism to still add to the user data words without modifying the upstream skiboot repo?

Um, isn't that how stuff usually works and how it currently works? When a new
flag gets defined, it gets added to the code? Are there flags I don't know
about?

Cyril

> 
> Patrick
> Sent from my iPhone
> 
> > On Apr 28, 2016, at 3:16 AM, Stewart Smith <stewart at linux.vnet.ibm.com> wrote:
> > 
> > Cyril Bur <cyril.bur at au1.ibm.com> writes:  
> >> These patches do the basic work to get libffs to be able to create entire FFS
> >> images. I've also worked on a tool to actually be able to do this.
> >> 
> >> I would appreciate people taking a look. I consider the first two patches
> >> fairly polished.  
> > 
> > From a relatively brief look, things look good.
> > 
> > Anything missing from being able to rip out all the bad ffs utils from
> > op-build?
> > 
> > 
> > -- 
> > Stewart Smith
> > OPAL Architect, IBM.
> > 
> > _______________________________________________
> > Skiboot mailing list
> > Skiboot at lists.ozlabs.org
> > https://lists.ozlabs.org/listinfo/skiboot  
> 
>