[Skiboot] [PATCH] SEL: Fix eSEL ID while logging eSEL event
stewart at linux.vnet.ibm.com
Tue Apr 26 09:54:32 AEST 2016
Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> On 01/07/2016 11:18 AM, Vasant Hegde wrote:
>> On 01/06/2016 10:46 AM, Stewart Smith wrote:
>>> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>>>> Commit 127a7dac added eSEL ID to SEL event in reverse order (0700 instead
>>>> of 0007). This code fixes this issue by adding ID in proper order.
>>> This was back in skiboot-5.1.0-beta2 - which means we've shipped systems
>>> producing these types of SEL events, so I don't think we can safely
>>> change that now - we may well be stuck with it.
>> This is a bug I introduced in the first place :-( The way we represent eSEL ID
>> is wrong. Also different than hostboot, OCC. Hence it will create confusions. So
>> its better to fix it.
>>> Is there a way to do this in a way that's backwards compatible?
>> I can't think of a way to have backward compatible.
> Oops .. Looks like I forgot to track couple of outstanding patches :-(
> Any update on this patch?
Want to resend it? I think it ends up being okay, but let's bring it up
for discussion again.
OPAL Architect, IBM.
More information about the Skiboot