[Skiboot] [PATCH] platforms/astbmc: Move prd_init calls to astbmc_early_init()

Stewart Smith stewart at linux.vnet.ibm.com
Tue Sep 15 16:39:22 AEST 2015

Jeremy Kerr <jk at ozlabs.org> writes:

> Hi Joel,
>>> --- a/platforms/astbmc/common.c
>>> +++ b/platforms/astbmc/common.c
>>> @@ -348,4 +348,6 @@ void astbmc_early_init(void)
>>>         /* Setup UART and use it as console with interrupts */
>>>         uart_init(true);
>>> +
>>> +       prd_init();
>> Should it always be last? Do we need a comment?
> There's no need for it to be early. I've added it last as each of the
> individual platform definitions called prd_init after
> astbmc_early_init(), so we have the smallest functional change here.
> Not sure we'd need a comment - it "does what it says on the tin".

Solidly agreed - I casually detest the pattern of "comment above
obviously named function" and umm and ahh over the day I'll go through
skiboot and rip out all of them.

Also, merged as of ef186c6

More information about the Skiboot mailing list