[Skiboot] [PATCH] platforms/astbmc: Move prd_init calls to astbmc_early_init()

Jeremy Kerr jk at ozlabs.org
Mon Sep 14 17:13:38 AEST 2015

Hi Joel,

>> --- a/platforms/astbmc/common.c
>> +++ b/platforms/astbmc/common.c
>> @@ -348,4 +348,6 @@ void astbmc_early_init(void)
>>         /* Setup UART and use it as console with interrupts */
>>         uart_init(true);
>> +
>> +       prd_init();
> Should it always be last? Do we need a comment?

There's no need for it to be early. I've added it last as each of the
individual platform definitions called prd_init after
astbmc_early_init(), so we have the smallest functional change here.

Not sure we'd need a comment - it "does what it says on the tin".



More information about the Skiboot mailing list