[Skiboot] [PATCH v2 0/8] Add attention support for BMC based machine

[Stewart Smith]

Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
> This patchset adds attention support for BMC based machine. With this
> during abort/assert we will be able to log eSEL event with OPAL backtrace
> and trigger host reboot.
>
> This patchset introduces attention support for BMC based machine.
> Patch 1-6 does various fixes to SEL code and does ipmi_msg pre-allocation.
> Patch 6-7 take care of moving FSP specific code, adding platform hook etc.
> Patch 8 implements attention support for BMC based machine.
>
> Changes in v2:
>   - Fixed corner case IPMI eSEL bug
>   - Removed redundant memory allocation in eSEL code path
>   - Preallocated ipmi_msg for PANIC event
>   - Created ti_buffer and bt_buf as global variable instead of local
>
> Vasant Hegde (8):
>   IPMI: Fix corner case eSEL logging issue
>   IPMI: Insert SEL event to IPMI queue head
>   IPMI: Avoid unnecessary ipmi_msg allocation
>   IPMI: Pre-allocate memory for PANIC event
>   IPMI: Move MAX_PEL_SIZE to ipmi.h
>   Move FSP specific abort() code to platform layer
>   platform: Add platform hook for terminate call
>   IPMI: Introduce attention call
>
>  core/exceptions.c            |   2 +-
>  core/utils.c                 |  20 ++------
>  hw/fsp/fsp-attn.c            |  26 +++++++++-
>  hw/ipmi/Makefile.inc         |   2 +-
>  hw/ipmi/ipmi-attn.c          |  85 ++++++++++++++++++++++++++++++++
>  hw/ipmi/ipmi-sel.c           | 113 ++++++++++++++++++++++++++++++++-----------
>  include/fsp.h                |   3 ++
>  include/ipmi.h               |  14 ++++++
>  include/platform.h           |   5 ++
>  libc/include/assert.h        |   5 --
>  libc/include/stdlib.h        |   9 ++--
>  platforms/astbmc/common.c    |   1 +
>  platforms/astbmc/firestone.c |   1 +
>  platforms/astbmc/garrison.c  |   1 +
>  platforms/astbmc/habanero.c  |   1 +
>  platforms/astbmc/palmetto.c  |   1 +
>  platforms/ibm-fsp/apollo.c   |   1 +
>  platforms/ibm-fsp/firenze.c  |   1 +
>  18 files changed, 234 insertions(+), 57 deletions(-)
>  create mode 100644 hw/ipmi/ipmi-attn.c
>
> -- 


Thanks, all merged as of 3904f94