[Skiboot] [PATCH 0/2] External tests

Cyril Bur cyril.bur at au1.ibm.com
Mon Sep 7 17:24:08 AEST 2015


I had to resist the urge to overengineer these tests. The current make
check infrastructure is nice to I wanted to make use of it, however, what
it doesn't allow very nice capturing of output from binaries.

For the external/ tools being unable to capture output from binaries is a
problem as tests for external/ tools often involved validating the
correctness of their output.

I added a bit of a harness that can used to simplify the process and I have
a few trivial tests for the gard tool as well. When I find cycles more may
appear.

For the gard tool, if people come across GUARD partitions with things (the
more complex the better really) in them, passing them to me would be nice,
I have doubts as to how realworld data1.bin actually is.

Cyril Bur (2):
  external/test: Create an external test harness
  external/gard/tests: Add tests for the gard tool

 external/gard/test/Makefile.check        |  27 +++++++++++
 external/gard/test/files/data1.bin       | Bin 0 -> 20480 bytes
 external/gard/test/results/00-list.err   |   0
 external/gard/test/results/00-list.out   |   5 ++
 external/gard/test/results/01-show_1.err |   0
 external/gard/test/results/01-show_1.out |   9 ++++
 external/gard/test/results/02-usage.err  |  18 +++++++
 external/gard/test/results/02-usage.out  |   0
 external/gard/test/test-gard             |   5 ++
 external/gard/test/test.sh               |   1 +
 external/gard/test/tests/00-list         |  10 ++++
 external/gard/test/tests/01-show_1       |  10 ++++
 external/gard/test/tests/02-usage        |  10 ++++
 external/test/test.sh                    |  80 +++++++++++++++++++++++++++++++
 14 files changed, 175 insertions(+)
 create mode 100644 external/gard/test/Makefile.check
 create mode 100644 external/gard/test/files/data1.bin
 create mode 100644 external/gard/test/results/00-list.err
 create mode 100644 external/gard/test/results/00-list.out
 create mode 100644 external/gard/test/results/01-show_1.err
 create mode 100644 external/gard/test/results/01-show_1.out
 create mode 100644 external/gard/test/results/02-usage.err
 create mode 100644 external/gard/test/results/02-usage.out
 create mode 100755 external/gard/test/test-gard
 create mode 120000 external/gard/test/test.sh
 create mode 100644 external/gard/test/tests/00-list
 create mode 100644 external/gard/test/tests/01-show_1
 create mode 100644 external/gard/test/tests/02-usage
 create mode 100755 external/test/test.sh

-- 
2.5.1



More information about the Skiboot mailing list