[Skiboot] [PATCH STABLE] hw/fsp/fsp-leds.c: use allocated buffer for FSP_CMD_GET_LED_LIST response

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Tue Oct 13 16:58:29 AEDT 2015

On 10/09/2015 11:34 AM, Vasant Hegde wrote:
> On 10/09/2015 11:12 AM, Stewart Smith wrote:
>> This bug has originated since day 1 (of public release), what was going on
>> was that we were incorrectly using PSI_DMA_LOC_COD_BUF as the *address*
>> to write to for the FSP to read rather than using that purely as the
>> TCE table.


>> Reported-by: Dionysius d. Bell <belldi at us.ibm.com>
> Thanks for reporting this issue! I'm still wondering how we missed this one in
> first place!
>> Signed-off-by: Stewart Smith <stewart at linux.vnet.ibm.com>
> As discussed, we will have trouble if we get multiple request simultaneously.
> Spec doesn't seems to tell anything.. I will cross check with FW folks later.


FW folks confirmed that MBOX can have only one outstanding message per class. So
this patch is enough. Please merge this to master branch.


More information about the Skiboot mailing list