[Skiboot] [PATCH 00/36] Big lot of sparse fixes

Stewart Smith stewart at linux.vnet.ibm.com
Tue Nov 10 15:17:54 AEDT 2015


This patchset fixes a few things for running sparse and getting meaningful
warnings out of it.

It then goes on to fix around 600 sparse warnings throughout skiboot.

For the majority of them, it's going to mean no actual code generation
changes for skiboot as skiboot itself is BE. But if writing unit tests
for some of this code, it will matter (if running them on an LE host).

Stewart Smith (36):
  Skip -std=gnu11 for sparse
  Properly annotate types.h for sparse
  Fix sparse warnings in init_boot_tracebuf()
  Fix sparse warning in trace repeat structure
  opal_table_entry members should be native endian
  Fixup sparse endian annotations for opal events and masks
  Fix sparse warnings in opal_trace_entry()
  sparse: opal_register() is CPU native endian arguments
  Fix two sparse warnings on __stack_chk_guard
  sparse: fix conversion of hdat slca_index
  sparse: fix endian conversions in hdata/iohub.c
  sparse: fix incorrect type warnings in hdata/fsp.c
  sparse: fix endian annotations in hdata/memory.c
  sparse: fix constant is so big warning in hw/xscom.c
  sparse: fix constant is so big it's long in hw/nx-rng.c
  sparse: fix warning constant is so big it is long in hw/slw.c
  sparse: fix warning constant is so big it is long in hw/psi.c
  sparse: fix warning constant is so big it is (unsigned) long in
    hw/p5ioc2.c
  sparse: Fix many constant is too big warninsg in p7ioc code
  sparse: fix endian conversion warnings in core/opal-msg.c
  sparse: fix endian annotation warnings in ipmi-rtc.c
  sparse: fix missing beXX_to_cpu() conversions in hdata/fsp.c
  sparse: fix beintXX_t degrades to integer warnings in hdata/iohub.c
  sparse: fix cast from restricted beint64_t in hdata/memory.c
  sparse: fix beint16_t degrades to int in hdata/hdif.c
  sparse: fix beint32_t degrades to int in hdata/pcia.c
  sparse: fix cast that discarded endian annotation in hdata/paca.c
  sparse: fix missing endian conversion in hdif pointer
  sparse: fix endian conversion for MDST table
  sparse: fix beint32_t degrades to int wantings in hdata/spira.c
  sparse: fix endian conversions in hw/occ.c
  sparse: fix incorrect type in assignment warning in hw/lpc-uart.c
  sparse: add missing endian conversion in fsp-attn.c
  sparse: correct endian conversion of sglist
  sparse: fix be64 degrades to integer warnings in fsp-mem-err.c
  sparse: fix incorrect type in assignment in fsp-mem-err.c

 Makefile.main            |   1 +
 Makefile.rules           |   4 +-
 core/interrupts.c        |   4 +-
 core/opal-msg.c          |   4 +-
 core/opal.c              |  15 +-
 core/trace.c             |   6 +-
 core/utils.c             |   3 +-
 hdata/fsp.c              |  16 +-
 hdata/hdif.c             |   2 +-
 hdata/hdif.h             |   2 +-
 hdata/iohub.c            |  30 +--
 hdata/memory.c           |   9 +-
 hdata/paca.c             |   2 +-
 hdata/pcia.c             |   2 +-
 hdata/spira.c            |   4 +-
 hdata/vpd.c              |   2 +-
 hw/fsp/fsp-attn.c        |   2 +-
 hw/fsp/fsp-dump.c        |   2 +-
 hw/fsp/fsp-mdst-table.c  |  23 +-
 hw/fsp/fsp-mem-err.c     |  26 +--
 hw/ipmi/ipmi-rtc.c       |   8 +-
 hw/lpc-uart.c            |   2 +-
 hw/nx-rng.c              |   2 +-
 hw/occ.c                 |  10 +-
 hw/p5ioc2.c              |   8 +-
 hw/p7ioc-inits.c         | 590 +++++++++++++++++++++++------------------------
 hw/p7ioc-phb.c           | 180 +++++++--------
 hw/p7ioc.c               |  54 ++---
 hw/psi.c                 |   2 +-
 hw/slw.c                 |  12 +-
 hw/xscom.c               |   2 +-
 include/fsp-mdst-table.h |   6 +-
 include/opal-internal.h  |  10 +-
 include/types.h          |   7 +-
 34 files changed, 529 insertions(+), 523 deletions(-)

-- 
2.1.4



More information about the Skiboot mailing list