[Skiboot] [PATCH] flash: Fix compilation error

Jeremy Kerr jk at ozlabs.org
Mon Jun 29 15:55:25 AEST 2015

Hi Vasant,

>> I think the patch itself is OK, but it's not clear how the old #include
>> would cause this error. The current make infrastructure builds with
>> -I<...>/libflash, so the current '#include <ecc.h>' would include this file.
> Ah! Sorry for the noise...
> For some reason my local tree didn't remove ecc.h from include directory..
> Hence I was hitting above error..
> Now I've cleaned it up and it works fine..

I still think we want this change, as it makes the ecc.h inclusion
consistent with the other libflash/ ones. It probably just needs a
different commit message, that's all.

[it might be worthwhile checking if there's other occurrences of the
same error too]



More information about the Skiboot mailing list