[Skiboot] [PATCH] flash: Fix compilation error

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Mon Jun 29 13:55:49 AEST 2015

On 06/29/2015 07:07 AM, Jeremy Kerr wrote:
> Hi Vasant,


>> On gcc v4.9.2 we are hitting below compiliation error.
>> [CC]  core/flash.o
>> 	core/flash.c: In function ‘flash_find_subpartition’:
>> 	core/flash.c:421:3: error: implicit declaration of function ‘ecc_buffer_size_minus_ecc’ [-Werror=implicit-function-declaration]
>> 	partsize = ecc_buffer_size_minus_ecc(*total_size);
>> 		      ^
>> 	core/flash.c:486:4: error: implicit declaration of function ‘ecc_size’ [-Werror=implicit-function-declaration]
>> 	*start += ecc_size(offset);
>> 			      ^
>> 	core/flash.c: In function ‘flash_load_resource’:
>> 	core/flash.c:580:3: error: implicit declaration of function ‘ecc_buffer_size_check’ [-Werror=implicit-function-declaration]
>> 	if (ecc_buffer_size_check(part_size)) {
>> 					    ^
> I think the patch itself is OK, but it's not clear how the old #include
> would cause this error. The current make infrastructure builds with
> -I<...>/libflash, so the current '#include <ecc.h>' would include this file.

Ah! Sorry for the noise...

For some reason my local tree didn't remove ecc.h from include directory..
Hence I was hitting above error..

Now I've cleaned it up and it works fine..


More information about the Skiboot mailing list