[Skiboot] [PATCH V3 6/6] external/pflash: Allow the libffs TOC to operate on to be specified

[Alistair Popple]

On Fri, 22 May 2015 15:30:17 Cyril Bur wrote:
> On systems with multiple TOCs it may be useful to be able to specify which
> one should be operated on.
> 
> Signed-off-by: Cyril Bur <cyril.bur at au1.ibm.com>
> ---

<snip>

> +	if (info ) {
> +		/*
> +		 * Don't pass through modfied TOC value if the modification 
was done
> +		 * because of --size, but still respect if it came from --toc 

because of --side?

(we
> +		 * assume the user knows what they're doing in that case)
> +		 */
> +		print_flash_info(flash_side ? 0 : ffs_toc);

So we don't respect --side with --info? I'm not saying we need to or that it 
even makes sense to, but it might be nice if we told the user that specifying 
--side with --info is invalid or ignored.

- Alistair

> +	}
>  	if (do_read)
>  		do_read_file(read_file, address, read_size);
>  	if (erase_all)