[Skiboot] [RFC PATCH] fsp/ipmi: Add the in-band IPMI support for FSP systems

[Alistair Popple]

Hi,

On Wed, 1 Jul 2015 12:30:19 Neelesh Gupta wrote:
> Hi Alistair,
> 
> Thanks for the review.
> 
> On 07/01/2015 12:02 PM, Alistair Popple wrote:
> > Hi Neelesh,
> >
> > A few comments below. The main question I have is do we even need to 
implement
> > a queue in this driver, given the FSP already has a message queue?
> 
> Yes, FSP queues the messages, but will not be aware of when the response
> received (it's asynchronous) so fsp-ipmi driver maintains the queue so that
> it queues the next request only after the current completed.

This doesn't matter for the IPMI layer - so long as the messages are sent in 
the order they're queued I don't see the issue with having multiple requests 
pending in the FSP layer.

> Without the list, we might send multiple IPMI mbox commands for different
> requests which FSP hardware doesn't expect.
> Going through your other comments, will respond/fix.

So the FSP driver can't cope with multiple messages of the same type being 
queued?

> Thanks,
> Neelesh.
> 
> >
> > Regards,
> >
> > Alistair
> >
> > On Wed, 24 Jun 2015 22:46:20 Neelesh Gupta wrote:
> >
>