[Skiboot] [RFC PATCH] fsp/ipmi: Add the in-band IPMI support for FSP systems

Neelesh Gupta neelegup at linux.vnet.ibm.com
Wed Jul 1 17:00:19 AEST 2015

Hi Alistair,

Thanks for the review.

On 07/01/2015 12:02 PM, Alistair Popple wrote:
> Hi Neelesh,
> A few comments below. The main question I have is do we even need to implement
> a queue in this driver, given the FSP already has a message queue?

Yes, FSP queues the messages, but will not be aware of when the response
received (it's asynchronous) so fsp-ipmi driver maintains the queue so that
it queues the next request only after the current completed.
Without the list, we might send multiple IPMI mbox commands for different
requests which FSP hardware doesn't expect.
Going through your other comments, will respond/fix.


> Regards,
> Alistair
> On Wed, 24 Jun 2015 22:46:20 Neelesh Gupta wrote:

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/skiboot/attachments/20150701/9144e2d0/attachment.html>

More information about the Skiboot mailing list