[Skiboot] [PATCH v2 0/2] New vpd hierarchial structure in DT

Stewart Smith stewart at linux.vnet.ibm.com
Fri Jan 30 16:04:40 AEDT 2015


Neelesh Gupta <neelegup at linux.vnet.ibm.com> writes:
> The following series adds the support to populate VPD nodes in
> hierarchial fashion in the device tree. It makes use of the
> parent-child relationship of SLCA entries before adding the
> individual vpd data to the corresponding nodes.
>
> Completely removed the switch-case in valid_child_entry() function
> as with the new logic, all the vpd nodes are created once during
> the first pass from dt_add_vpd_node(). It has led to creation
> of some new nodes which were not there in old DT, but think that
> is not a problem.
>
> Changes in v2:
> ==============
> - Found few VPDs missing when compared to what we see in the ASMI
>   page, they were also missing the older layout though. Included
>   them by tweaking the logic of slca entries traversal. Now, start
>   from the root entry (SLCA_ROOT_INDEX '0') and follow through its
>   all the children.
>
> Results:
>
> 1.
> [root at tul169p1 device-tree]# tree -d /proc/device-tree/vpd/
> /proc/device-tree/vpd/
> `-- root-node-vpd at a000
>     |-- enclosure at 1e00
>     |   |-- air-mover at 3a00
>     |   |-- air-mover at 3a01
>     |   |-- backplane at 800

<snip>

I'd love to see an addition to doc/device-tree/ describing the changes.

Although I'm not sure why we can't just add the loc-code to existing
entries.



More information about the Skiboot mailing list