[Skiboot] [PATCH 07/13] core/flash: Don't clobber rc in error path

Jeremy Kerr jk at ozlabs.org
Fri Feb 27 20:11:06 AEDT 2015

From: Joel Stanley <joel at jms.id.au>

When checking paramters for errors we set rc, but then simply return
OPAL_HARDWARE in the error path.

Signed-off-by: Joel Stanley <joel at jms.id.au>
Signed-off-by: Jeremy Kerr <jk at ozlabs.org>

 core/flash.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/core/flash.c b/core/flash.c
index cef34d9..187d7c2 100644
--- a/core/flash.c
+++ b/core/flash.c
@@ -323,7 +323,7 @@ static int64_t opal_flash_op(enum flash_op op, uint64_t id, uint64_t offset,
+	return rc;
 static int64_t opal_flash_read(uint64_t id, uint64_t offset, uint64_t buf,

More information about the Skiboot mailing list