[Skiboot] [PATCH 00/25] sparse cleanups

Cédric Le Goater clg at fr.ibm.com
Tue Feb 24 22:14:14 AEDT 2015


Hi,

I started running sparse on the OPAL code and found a few things 
that could help below. 

The be16, be32, be64 typedefs are the main issue to complete the 
cleanup. 

Cheers,

C.

Cédric Le Goater (25):
  sparse: add make variable C to run sparse when compiling skiboot
  sparse: MEMCONS_MAGIC is a long
  sparse: declare proc_chip_quirks as extern
  sparse: fix fonction declarations
  sparse: fix function argument test
  sparse: declare platform as extern
  sparse: hbrt_memcons can be static
  sparse: declare opal_err_info as static
  sparse: hmi_lock can be static
  sparse: psi_link_poll_active can be static
  sparse: state_str is unused
  sparse: fake_ymd and fake_hmsm can be static
  sparse: rtc_tod_state and rtc_tod_cache_dirty and be static
  sparse: fix fsp_fillmsg definition
  sparse: led_support can be static
  sparse: elog_write_to_host_head_state can be static
  sparse: epow_status can be static
  sparse: fsp_dpo_init_tb can be static
  sparse: libflash_debug is unused
  sparse: declare errno
  sparse: declare reboot_in_progress
  sparse: bt_backend can be static
  sparse: fix Using plain integer as NULL pointer warning
  sparse: fix declaration of fdt_strerror
  sparse: fix libc declarations

 Makefile.main                   |    3 +++
 Makefile.rules                  |   11 +++++++++++
 core/cpu.c                      |    2 +-
 core/exceptions.c               |    2 +-
 core/fast-reboot.c              |    7 +++++--
 core/hostservices.c             |    4 ++--
 core/init.c                     |    4 ++--
 core/platform.c                 |    2 ++
 hw/bt.c                         |    8 +-------
 hw/fake-rtc.c                   |    4 ++--
 hw/fsp/fsp-dpo.c                |    2 +-
 hw/fsp/fsp-elog-write.c         |    2 +-
 hw/fsp/fsp-epow.c               |    2 +-
 hw/fsp/fsp-leds.c               |    2 +-
 hw/fsp/fsp-rtc.c                |    4 ++--
 hw/fsp/fsp.c                    |    2 +-
 hw/psi.c                        |    2 +-
 include/chip.h                  |    2 +-
 include/console.h               |    2 +-
 include/cpu.h                   |    4 ++--
 include/errorlog.h              |    2 +-
 include/lpc.h                   |    2 +-
 include/opal-api.h              |   11 +++++++++--
 include/platform.h              |    2 +-
 include/skiboot.h               |    6 +++---
 libc/include/ctype.h            |   14 ++++++++------
 libc/stdlib/error.c             |    1 +
 libc/stdlib/strtol.c            |    2 +-
 libc/stdlib/strtoul.c           |    2 +-
 libfdt/fdt_strerror.c           |    2 +-
 libfdt/libfdt.h                 |    3 ++-
 libflash/libflash.c             |    2 --
 libpore/pore_inline_assembler.c |    4 ++--
 33 files changed, 73 insertions(+), 51 deletions(-)

-- 
1.7.10.4



More information about the Skiboot mailing list