[Skiboot] [RFC PATCH 1/3] powerpc/powernv: Check OPAL sensor calls exist
Cedric Le Goater
clg at fr.ibm.com
Sat Feb 21 07:18:11 AEDT 2015
On 02/20/2015 05:53 PM, Guenter Roeck wrote:
> On Fri, Feb 20, 2015 at 04:07:35PM +0100, Cédric Le Goater wrote:
>
> You should explain here why this patch is needed.
Yes. What it does is to check that the firmware exposes the service
this driver is using (OPAL_SENSOR_READ). I will fix it.
Thanks,
C.
>
>> Signed-off-by: Cédric Le Goater <clg at fr.ibm.com>
>> ---
>> arch/powerpc/platforms/powernv/opal-sensor.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/arch/powerpc/platforms/powernv/opal-sensor.c b/arch/powerpc/platforms/powernv/opal-sensor.c
>> index 4ab67ef7abc9..544292f2020f 100644
>> --- a/arch/powerpc/platforms/powernv/opal-sensor.c
>> +++ b/arch/powerpc/platforms/powernv/opal-sensor.c
>> @@ -72,6 +72,9 @@ static __init int opal_sensor_init(void)
>> struct platform_device *pdev;
>> struct device_node *sensor;
>>
>> + if (!opal_check_token(OPAL_SENSOR_READ))
>> + return -ENODEV;
>> +
>> sensor = of_find_node_by_path("/ibm,opal/sensors");
>> if (!sensor) {
>> pr_err("Opal node 'sensors' not found\n");
>> --
>> 1.7.10.4
>>
>
More information about the Skiboot
mailing list