[Skiboot] [PATCH 04/13] Don't run pollers in time_wait() when a lock is held

Cedric Le Goater clg at fr.ibm.com
Thu Feb 19 17:05:41 AEDT 2015


On 02/18/2015 09:58 PM, Benjamin Herrenschmidt wrote:
> On Wed, 2015-02-18 at 16:12 +0100, Cedric Le Goater wrote:
>> openpower systems call ipmi_wdt_init() which calls
>> ipmi_queue_msg_sync().
>>         
>> and then, they just loop endlessly in time_wait_ms(100) :/
> 
> Yes, it's a design bug in the ipmi code I just noticed. It shouldn't
> spin with a lock held. I'll try to fix that with Alistair today.

Thanks. I did not know how to handle it so I just reverted your patch 
for the moment.

C.



More information about the Skiboot mailing list