[Skiboot] [PATCH 08/13] fsp/console: Don't time_wait with lock held
Benjamin Herrenschmidt
benh at kernel.crashing.org
Wed Feb 18 14:57:24 AEDT 2015
Signed-off-by: Benjamin Herrenschmidt <benh at kernel.crashing.org>
---
hw/fsp/fsp-console.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/fsp/fsp-console.c b/hw/fsp/fsp-console.c
index d77d086..554dbde 100644
--- a/hw/fsp/fsp-console.c
+++ b/hw/fsp/fsp-console.c
@@ -819,7 +819,6 @@ static bool send_all_hvsi_close(void)
bool has_hvsi = false;
static const uint8_t close_packet[] = { 0xfe, 6, 0, 1, 0, 3 };
- lock(&fsp_con_lock);
for (i = 0; i < MAX_SERIAL; i++) {
struct fsp_serial *fs = &fsp_serials[i];
struct fsp_serbuf_hdr *sb = fs->out_buf;
@@ -839,9 +838,10 @@ static bool send_all_hvsi_close(void)
break;
time_wait_ms(500);
}
+ lock(&fsp_con_lock);
fsp_write_vserial(fs, close_packet, 6);
+ unlock(&fsp_con_lock);
}
- unlock(&fsp_con_lock);
return has_hvsi;
}
--
2.1.0
More information about the Skiboot
mailing list