[Skiboot] [PATCH 3/3] ... to prevent any potential poller recursions during lid load.
Ananth N Mavinakayanahalli
ananth at in.ibm.com
Tue Feb 17 03:40:05 AEDT 2015
On Mon, Feb 16, 2015 at 09:46:32PM +0530, Vasant Hegde wrote:
> n 02/16/2015 08:45 PM, Ananth N Mavinakayanahalli wrote:
> > See bz121430 for one such case.
>
> I think we shouldn't refer our bugzilla number here as its internal bugzilla.
Agreed.
...
> > +static int __hservice_lid_preload(const uint32_t lid)
> > +{
> > + struct hbrt_lid *hlid;
> > + void *buf;
> > + size_t len;
> > + int rc;
> > +
> > + hlid = zalloc(sizeof(struct hbrt_lid));
> > + if (!hlid) {
> > + prerror("HBRT: Could not allocate struct hbrt_lid\n");
> > + return -ENOMEM;
>
>
> Better OPAL_NO_MEM;
Sure. Will make the change.
> Rest looks good.
Thanks for the review.
Ananth
More information about the Skiboot
mailing list