[Skiboot] [PATCH 01/11] core: add a platform op to read sensors

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 12 18:42:19 AEDT 2015


C├ędric Le Goater <clg at fr.ibm.com> writes:
> +static int64_t opal_sensor_read(uint32_t sensor_hndl, int token,
> +		uint32_t *sensor_data)
> +{
> +	if (platform.sensor_read)
> +		return platform.sensor_read(sensor_hndl, token, sensor_data);
> +
> +	return OPAL_UNSUPPORTED;
> +}

It seems that previous behavior is to return OPAL_PARAMETER when
OPAL_SENSOR_READ is called with an unsupported sensor handle (at least
from my reading of parse_sensor_id in hw/fsp/fsp-sensor.c)

It would also be great if you document the OPAL_SENSOR_READ API while
you're at it too.

It seems that on non-fsp systems you would have gotten OPAL_PARAMETER
back as kernel should have been calling OPAL_CHECK_TOKEN first.



More information about the Skiboot mailing list