[Skiboot] [PATCH v2 2/2] prd: PRD framework

Benjamin Herrenschmidt benh at au1.ibm.com
Thu Feb 12 17:03:48 AEDT 2015

On Thu, 2015-02-12 at 15:06 +1100, Stewart Smith wrote:
> Why is this a platform op? It seems identical for the time being... or
> is it just missing in rhesus?

The external irq is a platform op because it depends on the device
connected to the P8 pin which is platform specific (BMC, Rhesus
EC, ...). However the local error interrupts is ... local :) So it
doesn't need to be a platform op at all.

The only thing here is whether we enable it as in, whether we enable
the ipoll mask, and we only do that as a result of hbrtd kicking in,
which should only happen on platforms without an FSP, so we might have
some conditionals in that area, but I agree, the interrupt itself
doesn't need to be abstracted.


More information about the Skiboot mailing list