[Skiboot] [PATCH v2 2/3] opal: Check Core FIRs to find the reason for Malfunction Alert.

Stewart Smith stewart at linux.vnet.ibm.com
Thu Feb 12 16:54:08 AEDT 2015


Mahesh J Salgaonkar <mahesh at linux.vnet.ibm.com> writes:
> @@ -337,7 +454,7 @@ static int64_t opal_handle_hmi(void)
>  	struct OpalHMIEvent hmi_evt;
>  
>  	memset(&hmi_evt, 0, sizeof(struct OpalHMIEvent));
> -	hmi_evt.version = OpalHMIEvt_V1;
> +	hmi_evt.version = OpalHMIEvt_V2;
>  
>  	lock(&hmi_lock);
>  	hmer = mfspr(SPR_HMER);		/* Get HMER register value */

It would be better if you only sent v2 in the event of something not
supported by V1.

Please also document in doc/opal-api



More information about the Skiboot mailing list