[Skiboot] [PATCH 00/10] Replace abort() with assert() where possible

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Wed Feb 11 02:49:53 AEDT 2015


On 02/10/2015 08:44 PM, Ananth N Mavinakayanahalli wrote:
> We currently populate Terminate Immediate areas only on an assert().
> 
> However, at various places in the code, we still call abort() directly.
> This prevents the attn on FSP to gather invaluable debug data.
> 
> Change abort() to assert() wherever possible.

Patchset looks good. For entire patchset

Reviewed-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>


-Vasant

> ---
> 
> Ananth N Mavinakayanahalli (10):
>       mem-region: Change aborts to asserts
>       cpu: Change abort to assert
>       hostservices: Change abort to assert
>       device: Change aborts to asserts
>       init: Change aborts to asserts
>       lock: Change abort to assert
>       opal: Change abort to assert
>       interrupts: Change abort to assert
>       hdata: Change abort to assert
>       chiptod: Change aborts to asserts
> 
> 
>  core/cpu.c          |    2 +-
>  core/device.c       |   10 +++++-----
>  core/hostservices.c |    2 +-
>  core/init.c         |    4 ++--
>  core/interrupts.c   |    2 +-
>  core/lock.c         |    2 +-
>  core/mem_region.c   |   10 +++++-----
>  core/opal.c         |    2 +-
>  hdata/memory.c      |    2 +-
>  hdata/paca.c        |    2 +-
>  hw/chiptod.c        |    4 ++--
>  11 files changed, 21 insertions(+), 21 deletions(-)
> 
> _______________________________________________
> Skiboot mailing list
> Skiboot at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/skiboot
> 



More information about the Skiboot mailing list