[Skiboot] [PATCH 02/22] FSP/LEDS: Remove duplicate fsp_msg allocation

Vasant Hegde hegdevasant at linux.vnet.ibm.com
Thu Feb 5 19:38:27 AEDT 2015


Remove duplicate fsp_msg allocation introduced by commit fa79cecc45c2.

Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
---
 hw/fsp/fsp-leds.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/fsp/fsp-leds.c b/hw/fsp/fsp-leds.c
index 1c45ccc..c6232d5 100644
--- a/hw/fsp/fsp-leds.c
+++ b/hw/fsp/fsp-leds.c
@@ -281,7 +281,7 @@ static void fsp_spcn_set_led_completion(struct fsp_msg *msg)
 	if (!smsg) {
 		prerror("LED: Failed to allocate FSP_RSP_SET_LED_STATE\n");
 	} else {
-		if (fsp_queue_msg(msg, fsp_freemsg)) {
+		if (fsp_queue_msg(smsg, fsp_freemsg)) {
 			prerror("LED: Failed to queue FSP_RSP_SET_LED_STATE\n");
 		}
 	}
@@ -335,7 +335,7 @@ static int fsp_msg_set_led_state(char *loc_code, bool command, bool state)
 			prerror("LED: Could not allocate "
 				"FSP_RSP_SET_LED_STATE|FSP_STATUS_INVALID_LC\n");
 		} else {
-			if (fsp_queue_msg(fsp_mkmsg(cmd, 0), fsp_freemsg)) {
+			if (fsp_queue_msg(msg, fsp_freemsg)) {
 				prerror("LED: Couldn't queue "
 					"FSP_RSP_SET_LED_STATE"
 					"|FSP_STATUS_INVALID_LC\n");



More information about the Skiboot mailing list