[Skiboot] [PATCH v2 4/4] ipmi/wdt: Add ipmi watchdog timer support

[Alistair Popple]

Hi,

> > index 99c2fd9..6489b7a 100644
> > --- a/core/ipmi.c
> > +++ b/core/ipmi.c
> > @@ -153,6 +153,12 @@ static void ipmi_get_message_flags_complete(struct
> > ipmi_msg *msg)> 
> >         prlog(PR_DEBUG, "IPMI Get Message Flags: %02x\n", flags);
> > 
> > +       /* Once we see an interrupt we assume the payload has
> > +        * booted. We disable the wdt and let the OS setup its own
> > +        * wdt. */
> > +       if (flags & IPMI_MESSAGE_FLAGS_WATCHDOG_PRE_TIMEOUT)
> > +               ipmi_wdt_stop();
> 
> I see that this will send a IPMI_SET_WDT to the BMC. Do you also need
> to clear the flag?
> 

That's a good question. I have no idea. I will run a few tests and see, the 
specification does not seem entirely clear in this regard.

Regards,

Alistair