[Skiboot] [PATCH v3] IPMI: Fix eSEL logging

[Vasant Hegde]

On 08/14/2015 01:19 PM, Stewart Smith wrote:
> Vasant Hegde <hegdevasant at linux.vnet.ibm.com> writes:
>> Presently we are passing PEL log without adding Extended SEL record.
>> Hence logging eSEL event is failing.
>>
>> This patch sends Extended SEL structure before sending actual PEL log.
>> So that BMC understands its eSEL log and logs it appropriately.
>>
>> eSEL format:
>>   <IPMI SEL header> : <eSEL record> : <PEL data>
>>
>> Note that we use sensor type "System Event (0x12)" for logging OPAL
>> events.
>>
>> Signed-off-by: Vasant Hegde <hegdevasant at linux.vnet.ibm.com>
>> Cc: Alistair Popple <alistair at popple.id.au>
>> Cc: Jeremy Kerr <jk at ozlabs.org>
> 
> Merged, although I have just noticed this on a habanero:
> 
> 11	08/14/2015 07:24:35	Boot Count	OEM	Invalid Offset
> for this SensorType - Asserted
> 
> with the content of "Save Event Logs" being:

Stewart,

I tried skiboot master on my firestone machine.  Everything worked fine for me.

ipmitool -I lanplus -H fir01 -U ADMIN -P admin sensor get 'Boot Count'
Locating sensor record...
Sensor ID              : Boot Count (0x5f)
 Entity ID             : 34.0 (BIOS)
 Sensor Type (Discrete): Unknown (0xC3) (0xc3)
 Sensor Reading        : 0h
 Event Message Control : Per-threshold
 OEM                   : 0

sel list and get also worked fine.

-Vasant

> 
> 
>       |Record|           |GenID|GenID |      |Sensor|        |EvtDir|Event|Event|Event|
>   ID  | Type | TimeStamp |(Low)|(High)|EvMRev| Type |Sensor #| Type |Data1|Data2|Data3|
> ------|------|-----------|-----|------|------|------|--------|------|-----|-----|-----|
>  0013h|   02h| 55cd9b77h |  20h|   00h|   04h|   08h|     5eh|   efh|  00h|  ffh|  ffh|
>  0012h|   02h| 55cd9b77h |  20h|   00h|   04h|   08h|     5dh|   efh|  00h|  ffh|  ffh|
>  0011h|   02h| 55cd9b77h |  20h|   00h|   04h|   09h|     1ch|   6fh|  00h|  ffh|  ffh|
>  0010h|   02h| 55cd9b77h |  20h|   00h|   04h|   07h|     0dh|   efh|  00h|  ffh|  ffh|
>  000fh|   02h| 55cd9b77h |  20h|   00h|   04h|   22h|     04h|   6fh|  05h|  ffh|  ffh|
>  000eh|   02h| 55cd9b76h |  20h|   00h|   04h|   07h|     08h|   09h|  00h|  ffh|  ffh|
>  000dh|   02h| 55cd97b7h |  20h|   00h|   04h|   0fh|     05h|   6fh|  c2h|  13h|  00h|
>  000ch|   02h| 55cd97b4h |  20h|   00h|   04h|   0fh|     05h|   6fh|  c2h|  07h|  00h|
>  000bh|   02h| 55cd97b3h |  20h|   00h|   04h|   c3h|     50h|   6fh|  01h|  ffh|  ffh|
>  000ah|   02h| 55cd97abh |  20h|   00h|   04h|   22h|     04h|   6fh|  00h|  ffh|  ffh|
>  0009h|   02h| 55cd979dh |  20h|   00h|   04h|   07h|     08h|   09h|  01h|  ffh|  ffh|
>  0008h|   02h| 55cd9798h |  20h|   00h|   04h|   0fh|     05h|   6fh|  c2h|  13h|  00h|
>  0007h|   02h| 55cd9792h |  20h|   00h|   04h|   09h|     1ch|   efh|  00h|  ffh|  ffh|
>  0006h|   02h| 55cd978fh |  20h|   00h|   04h|   0fh|     05h|   6fh|  c2h|  01h|  00h|
>  0005h|   02h| 55cd977dh |  20h|   00h|   04h|   0fh|     05h|   6fh|  c2h|  14h|  00h|
>  0004h|   02h| 55cd977dh |  20h|   00h|   04h|   22h|     04h|   6fh|  0bh|  ffh|  ffh|
>  0003h|   02h| 55cd9779h |  20h|   00h|   04h|   08h|     5eh|   6fh|  00h|  ffh|  ffh|
>  0002h|   02h| 55cd9779h |  20h|   00h|   04h|   08h|     5dh|   6fh|  00h|  ffh|  ffh|
>  0001h|   02h| 55cd9779h |  20h|   00h|   04h|   07h|     0dh|   6fh|
>   00h|  ffh|  ffh|
> 
> 
> Can you please look into this and find out what's going on?
>