[Skiboot] [PATCH v1 0/5] New HBRT interfaces

[Jeremy Kerr]

Hi Stewart,


> So, from my understanding the htmgt_pass_thru is strictly for
> manufacturing/debug and this is in no way going to be a stable API?
>
> How can we ensure that we very *very* *VERY* much communicate this?
>
> I'm thinking we perhaps need a
> --i-am-part-of-manufacturing-or-acknowledge-that-I-am-about-to-make-my-computer-explode
> switch that *must* be specified before running said commands?

How about we make this a compile-time flag, which removes the 
possibility of invoking these manufacturing/system test commands?

( CFLAGS += -DDANGEROUS )

Distros wouldn't be specifying this, so the standard tools wouldn't 
allow these.

> This all being said, why do we need a passthrough rather than just
> specify the commands that can be sent down?

Because we don't want to couple opal-prd code to the HBRT/HTMGT 
implementation.

Cheers,


Jeremy