[Skiboot] [PATCH v1 0/5] New HBRT interfaces

[Stewart Smith]

Neelesh Gupta <neelegup at linux.vnet.ibm.com> writes:

> The patch series implements the support for executing HBRT interfaces
> through opal-prd as client. The first 3 patches in this series, refactor
> the existing code along with fixing and cleaning up minor issues. The
> following 2 patches enable the support of HBRT 'run_command',
> 'htmgt_pass_thru' and 'apply_attr_override'.
>
> I have tested the 'htmgt_pass_thru' and 'apply_attr_override' interfaces
> integrating with the HBRT code and these interfaces work fine.
> 'run_command' interface can be tested later when the HBRT code is
> ready.


So, from my understanding the htmgt_pass_thru is strictly for
manufacturing/debug and this is in no way going to be a stable API?

How can we ensure that we very *very* *VERY* much communicate this?

I'm thinking we perhaps need a
--i-am-part-of-manufacturing-or-acknowledge-that-I-am-about-to-make-my-computer-explode
switch that *must* be specified before running said commands?

This all being said, why do we need a passthrough rather than just
specify the commands that can be sent down?

>From talking to Patrick, he's really careful about ensuring HBRT
compatibility, but when we're passing things through, we are now adding
an expectation that things won't randomly change between firmware
versions (no matter how much we say they will, people will assume they
won't). So we likely have a shared concern on this.