[PATCH] discover/udev.c: Added warning in system status log

Lulu_Su at wistron.com Lulu_Su at wistron.com
Thu Oct 7 13:33:45 AEDT 2021


Hi Jeremy,

>> Based on the previous discussion, I amended the conditions as
>> follows:
>>         1. When the device sda is mounted, use ID_PATH to determine 
>> that sad1 and sda are the same device.
>>         2. When a new device (sdc) is detected, the warning will be 
>> displayed only once; the Boolean value will not be cleared until the 
>> device is removed.
>> Therefore, the warning will only be displayed once. When a new device
>> (sdc) with the same UUID is detected, and when the user repeatedly 
>> mounts the same device (sdc), it will still be displayed again.
>> Hope this modification meets your suggestion, thank you very much~

> You could even do this without the udev_handle_dev_remove changes (which clear the dev_warn flag); we've warned about sda already, so I don't see much need to re-generate the warning later.

Allow me to clarify that this warning is not displayed when device sda is mounted, nor when its partition sda1 is detected.
If another device (sdc) with the same UUID is detected, this warning will be displayed only once.

That is, the warning is only issued when a device (sdc) is detected that cannot be successfully mounted to the petitboot list; the regenerated warning is necessary when the user removes the device (sdc) and tries to mount it again, or mounts another device with the same UUID.

> If you could send this as a proper commit, I can apply to the tree.

OK, I will send commit later.
Thank you for all your assistance, I really appreciate your help in solving the problem.

Regards,

Lulu Su


---------------------------------------------------------------------------------------------------------------------------------------------------------------
This email contains confidential or legally privileged information and is for the sole use of its intended recipient. 
Any unauthorized review, use, copying or distribution of this email or the content of this email is strictly prohibited.
If you are not the intended recipient, you may reply to the sender and should delete this e-mail immediately.
---------------------------------------------------------------------------------------------------------------------------------------------------------------



More information about the Petitboot mailing list