[PATCH v1 4/5] pb-discover: Fix signal handler

Geoff Levand geoff at infradead.org
Mon May 4 04:16:54 AEST 2020


Hi Jeremy,

On 5/2/20 11:00 PM, Jeremy Kerr wrote:
>> -static void sigint_handler(int __attribute__((unused)) signum)
>> +static void sigint_handler(int signum)
>>  {
>>  	running = 0;
>> +	signal(signum, sigint_handler);
> 
> But this shouldn't be needed; invoking the signal shouldn't change the
> handler - at least on Linux. Do you have a specific OS implementation
> that requires the signal to be re-registered?

I've never experienced needing to do this, but I though to add it in
to be more compatible.  I don't think it matters that much to have it
or not.  Can you think of some problem having it could cause?

-Geoff





More information about the Petitboot mailing list