[PATCH v1 4/5] pb-discover: Fix signal handler

Jeremy Kerr jk at ozlabs.org
Sun May 3 16:00:59 AEST 2020

Hi Geoff,

> -static int running;
> +static volatile sig_atomic_t running;

OK, looks good.
> -static void sigint_handler(int __attribute__((unused)) signum)
> +static void sigint_handler(int signum)
>  {
>  	running = 0;
> +	signal(signum, sigint_handler);

But this shouldn't be needed; invoking the signal shouldn't change the
handler - at least on Linux. Do you have a specific OS implementation
that requires the signal to be re-registered?



More information about the Petitboot mailing list