[PATCH 2/2] lib/file: Avoid off-by-one error in array

Samuel Mendoza-Jonas sam at mendozajonas.com
Tue Mar 20 13:46:22 AEDT 2018


Fixes Coverity defect CIDs 143606, 143610

Signed-off-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>
---
 lib/file/file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/file/file.c b/lib/file/file.c
index 0d18788..57a2519 100644
--- a/lib/file/file.c
+++ b/lib/file/file.c
@@ -37,7 +37,7 @@ int copy_file_secure_dest(void *ctx, const char *source_file,
 		char **destination_file)
 {
 	char readlink_buffer[MAX_FILENAME_SIZE + 1];
-	char dest_filename[MAX_FILENAME_SIZE] = "";
+	char dest_filename[MAX_FILENAME_SIZE + 1] = "";
 	char template[] = "/tmp/petitbootXXXXXX";
 	FILE *destination_handle, *source_handle;
 	int destination_fd, result = 0;
-- 
2.16.2



More information about the Petitboot mailing list