[PATCH 1/2] discover/pxe-parser: Avoid potential null dereference
Samuel Mendoza-Jonas
sam at mendozajonas.com
Tue Mar 20 13:46:21 AEDT 2018
Fixes Coverity defect CID 149918
Signed-off-by: Samuel Mendoza-Jonas <sam at mendozajonas.com>
---
discover/pxe-parser.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/discover/pxe-parser.c b/discover/pxe-parser.c
index d2ebaab..fd8b8e8 100644
--- a/discover/pxe-parser.c
+++ b/discover/pxe-parser.c
@@ -273,12 +273,14 @@ static void pxe_conf_parse_cb(struct load_url_result *result, void *data)
if (!data)
return;
+ if (!result)
+ goto out_clean;
handler = talloc_parent(conf);
- if (result && result->status == LOAD_OK)
+ if (result->status == LOAD_OK)
rc = read_file(conf, result->local, &buf, &len);
- if (!result || result->status != LOAD_OK || rc) {
+ if (result->status != LOAD_OK || rc) {
/* This load failed so try the next available filename */
info = conf->parser_info;
if (!info->pxe_conf_files) {
--
2.16.2
More information about the Petitboot
mailing list