[Pdbg] [PATCH v2 13/15] main: Convert getcfam/putcfam to use path based targeting

[Amitay Isaacs]

On Thu, 2018-11-15 at 15:13 +1100, Alistair Popple wrote:
> On Wednesday, 14 November 2018 4:42:59 PM AEDT Amitay Isaacs wrote:
> > On Tue, 2018-11-13 at 16:01 +1100, Alistair Popple wrote:
> > > Hi Amitay,
> > > 
> > > >  test_result 0 <<EOF
> > > > 
> > > > -p0:0xc09 = HEX8
> > > > +/kernelfsi at 0: 0xc09 = HEX8
> > > 
> > > We may have discussed this sorry if I'm changing my mind but can
> > > we
> > > keep the
> > > output the same for the time being? ie. Something like ("p%d",
> > > pdbg_target_index(fsi))?
> > 
> > Well the question is what targets we want for getcfam/putcfam?
> 
> I think just the root/top level fsi targets are fine for now. In
> practice we 
> don't have any FSI children that would need translation atm.
>  
> > As per your thinking, if we want pib target to be selected for
> > getcfam/putcfam commands, then the the existing output makes sense.
> > In that case, the implementation should find the fsi target for
> > selected pib target for actual operations.
> 
> I don't think we actually want the pib targets selected. I'm really
> just 
> talking about the output formatting which it would be nice to keep
> the same - 
> ie:
> 
> "p<chip index>:<addr> = <value>"

I find it a bit confusing since 'p' is used to indicate pib class (-p). 
It's also the same as processor (or chip).  

For example, how do you do getcfam on second chip? (Does that even make
sense?  Read more pdfs Amitay!)

If we need fsi target, then may be "-P fsi1" will work provided we have
the second fsi target with correct index.  If there is no fsi target
with index 1, then we might have to actually know the topology to
select the right fsi target (e.g. "-P fsi/fsi").  In that how do we
generate the output "p1: <addr> = <value>"?

It's more intuitive if we always use pib as a package/processor/chip.
It's easier to either use "-p 1" or "-P pib1" for second processor/chip
and then we can internally pick the "right" target to actually perform
the fsi_read() operation.

Amitay.
-- 

It is better to be hated for what you are, than loved for what you are not.
  - Andre Gide