[Pdbg] [PATCH v2 13/15] main: Convert getcfam/putcfam to use path based targeting

[Alistair Popple]

On Wednesday, 14 November 2018 4:42:59 PM AEDT Amitay Isaacs wrote:
> On Tue, 2018-11-13 at 16:01 +1100, Alistair Popple wrote:
> > Hi Amitay,
> > 
> > >  test_result 0 <<EOF
> > > 
> > > -p0:0xc09 = HEX8
> > > +/kernelfsi at 0: 0xc09 = HEX8
> > 
> > We may have discussed this sorry if I'm changing my mind but can we
> > keep the
> > output the same for the time being? ie. Something like ("p%d",
> > pdbg_target_index(fsi))?
> 
> Well the question is what targets we want for getcfam/putcfam?

I think just the root/top level fsi targets are fine for now. In practice we 
don't have any FSI children that would need translation atm.
 
> As per your thinking, if we want pib target to be selected for
> getcfam/putcfam commands, then the the existing output makes sense.
> In that case, the implementation should find the fsi target for
> selected pib target for actual operations.

I don't think we actually want the pib targets selected. I'm really just 
talking about the output formatting which it would be nice to keep the same - 
ie:

"p<chip index>:<addr> = <value>"

- Alistair

> Does that work?
> 
> > >  EOF
> > >  
> > >  do_skip
> > > 
> > > -test_run $PDBG -p0 getcfam 0xc09
> > 
> > This test should still pass though? Do you think it would it be
> > better to just
> > add another test or are you do think the other selection tests cover
> > this case
> > adequately?
> > 
> > - Alistair
> > 
> > > +test_run $PDBG -P fsi getcfam 0xc09
> > > 
> > >  test_result 0 <<EOF
> > >  p0:0xf000f = HEX16
> 
> Amitay.