[Pdbg] [PATCH] Makefile.am: Fix dependencies for specific .dtb.o files

[Cyril Bur]

On Mon, 2017-12-11 at 12:02 +1100, Alistair Popple wrote:

> > Nak. The dtb is built from the dts, so the rule should be  dtb: dts.

> > There's an additional dependency on the dtsi, so we make sure that is

> > listed too.

> >

> > Think of it like a C file:

> >

> > foo.o: foo.c foo.h

> >

> > Please take this patch instead:

> >

> >  https://lists.ozlabs.org/pipermail/pdbg/2017-December/000000.html

>

> dtc supports the `-d` option:

>

>   -d, --out-dependency <arg>

>         Output dependency file

>

> If we were going to do this properly we'd just teach make how to generate the

> dependencies automatically. In the meantime I agree - removing the dependencies

> doesn't seem right. Cyril does Joel's patch above fix the issue you were seeing?

>


Yeah should fix the build issue.

Can we add .INTERMEDIATE to Joels patch? Otherwise I'm pretty sure its
going to leave the .dtb files sitting around... If we do want that we
should mark the %.dtb rule as precious and also add to .gitignore... either
way, just... consistency :)

Cyril

> Regards,

>

> Alistair

>

> >

> > Cheers,

> >

> > Joel

> >

> > >

> > >  %.dtb: %.dts

> > >         $(DTC_V)dtc -q -i$(dir $@) -I dts $< -O dtb > $@

> > > --

> > > 2.15.1

> > >

> > > --

> > > Pdbg mailing list

> > > Pdbg at lists.ozlabs.org

> > > https://lists.ozlabs.org/listinfo/pdbg

>

>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ozlabs.org/pipermail/pdbg/attachments/20171211/45d74d10/attachment.html>